]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 10 Aug 2021 08:44:13 +0000 (11:44 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 5 Nov 2021 09:19:50 +0000 (10:19 +0100)
BugLink: https://bugs.launchpad.net/bugs/1949397
commit 02d438f62c05f0d055ceeedf12a2f8796b258c08 upstream.

This error path return success but it should propagate the negative
error code from devm_clk_get().

Fixes: 6c247393cfdd ("thermal: exynos: Add TMU support for Exynos7 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210810084413.GA23810@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/thermal/samsung/exynos_tmu.c

index e9a90bc23b11d53d9e37bdeff645cbdb700910b1..f4ab4c5b4b626cfff4f9591a84b9ad14403375a7 100644 (file)
@@ -1073,6 +1073,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
                data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");
                if (IS_ERR(data->sclk)) {
                        dev_err(&pdev->dev, "Failed to get sclk\n");
+                       ret = PTR_ERR(data->sclk);
                        goto err_clk;
                } else {
                        ret = clk_prepare_enable(data->sclk);