]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/radeon/dpm: fix uninitialized read from stack in kv_dpm_late_enable
authorDave Jones <davej@redhat.com>
Fri, 31 Jan 2014 02:17:30 +0000 (21:17 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 6 Feb 2014 17:22:49 +0000 (12:22 -0500)
If we take the false branch of the if quoted in the diff below, we
end up doing a return ret, without ever having initialized it.

Picked up by coverity.

Signed-off-by: Dave Jones <davej@fedoraproject.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/kv_dpm.c

index b6e01d5d2cced24edc67e773c84cba33a6d5fef8..351db361239db1d2800f845b2e9e9d02d541cc2b 100644 (file)
@@ -1223,7 +1223,7 @@ int kv_dpm_enable(struct radeon_device *rdev)
 
 int kv_dpm_late_enable(struct radeon_device *rdev)
 {
-       int ret;
+       int ret = 0;
 
        if (rdev->irq.installed &&
            r600_is_internal_thermal_sensor(rdev->pm.int_thermal_type)) {