]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
scsi: libcxgbi: remove redundant check and close on csk
authorColin Ian King <colin.king@canonical.com>
Thu, 7 Sep 2017 13:51:33 +0000 (14:51 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 16 Sep 2017 01:44:36 +0000 (21:44 -0400)
csk is always null on the error return path and so the non-null check
and call to cxgbi_sock_closed on csk is redundant and can be removed.

Detected by: CoverityScan CID#114329 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxgbi/libcxgbi.c

index 512c8f1ea5b06efd4d42c2eed805be9e6a23d533..da36c2de069e7f7b11b9281bfda1e02ad6f916df 100644 (file)
@@ -688,8 +688,6 @@ rel_neigh:
 
 rel_rt:
        ip_rt_put(rt);
-       if (csk)
-               cxgbi_sock_closed(csk);
 err_out:
        return ERR_PTR(err);
 }