]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
mtd: nand: lpc32xx_slc: Handle return value of clk_prepare_enable.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 1 Aug 2017 11:38:06 +0000 (17:08 +0530)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Wed, 23 Aug 2017 14:49:19 +0000 (16:49 +0200)
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/lpc32xx_slc.c

index a0669a33f8fe61334a07ec058989d865f3c6ab73..80c282914586a1636bddd6ff469eb7505f881eff 100644 (file)
@@ -840,7 +840,9 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
                res = -ENOENT;
                goto err_exit1;
        }
-       clk_prepare_enable(host->clk);
+       res = clk_prepare_enable(host->clk);
+       if (res)
+               goto err_exit1;
 
        /* Set NAND IO addresses and command/ready functions */
        chip->IO_ADDR_R = SLC_DATA(host->io_base);
@@ -972,9 +974,12 @@ static int lpc32xx_nand_remove(struct platform_device *pdev)
 static int lpc32xx_nand_resume(struct platform_device *pdev)
 {
        struct lpc32xx_nand_host *host = platform_get_drvdata(pdev);
+       int ret;
 
        /* Re-enable NAND clock */
-       clk_prepare_enable(host->clk);
+       ret = clk_prepare_enable(host->clk);
+       if (ret)
+               return ret;
 
        /* Fresh init of NAND controller */
        lpc32xx_nand_setup(host);