hwmon: (adm1025) Fix overflows seen when writing voltage limits

Writes into voltage limit attributes can overflow due to an unbound
multiplication.

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/adm1025.c b/drivers/hwmon/adm1025.c
index d6c767ace9166d1c0ee54105d69f7ecd551516e8..1abb4609b41235bf6f84787eed67a4b706981618 100644 (file)
--- a/drivers/hwmon/adm1025.c
+++ b/drivers/hwmon/adm1025.c
@@ -93,7 +93,7 @@ static const int in_scale[6] = { 2500, 2250, 3300, 5000, 12000, 3300 };
 
 #define IN_FROM_REG(reg, scale)        (((reg) * (scale) + 96) / 192)
 #define IN_TO_REG(val, scale)  ((val) <= 0 ? 0 : \
-                                (val) * 192 >= (scale) * 255 ? 255 : \
+                                (val) >= (scale) * 255 / 192 ? 255 : \
                                 ((val) * 192 + (scale) / 2) / (scale))
 
 #define TEMP_FROM_REG(reg)     ((reg) * 1000)