critic: avoid $a, $b special package variables

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/Proxmox/Sys/Block.pm b/Proxmox/Sys/Block.pm
index bb2fc907a84d37bbf61cf23f82c6eeba31e262b1..cba42a884e916e2a89bf83770f729a894ee95748 100644 (file)
--- a/Proxmox/Sys/Block.pm
+++ b/Proxmox/Sys/Block.pm
@@ -16,10 +16,10 @@ use base qw(Exporter);
 our @EXPORT_OK = qw(get_cached_disks wipe_disk partition_bootable_disk);
 
 my sub is_same_file {
-    my ($a, $b) = @_;
+    my ($file_a, $file_b) = @_;
 
-    my ($dev_a ,$ino_a) = stat($a);
-    my ($dev_b, $ino_b) = stat($b);
+    my ($dev_a ,$ino_a) = stat($file_a);
+    my ($dev_b, $ino_b) = stat($file_b);
 
     return 0 if !($dev_a && $dev_b && $ino_a && $ino_b);
 

diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm
index 6b87e4d6bcb4059e9b41aa4e29cd4c74928799b5..ba368c1a4bd393f3af663e9a6c41900639e8494e 100644 (file)
--- a/Proxmox/Sys/Net.pm
+++ b/Proxmox/Sys/Net.pm
@@ -144,10 +144,10 @@ sub get_ip_config {
        };
 
        my $addresses = `ip -o a s $name`;
-       foreach my $a (split /\n/,$addresses) {
-           my ($family, $ip, $prefix) = $a =~ m/^\Q$index\E:\s+\Q$name\E\s+(inet|inet6)\s+($IPRE)\/(\d+)\s+/;
+       for my $addr_line (split /\n/,$addresses) {
+           my ($family, $ip, $prefix) = $addr_line =~ m/^\Q$index\E:\s+\Q$name\E\s+(inet|inet6)\s+($IPRE)\/(\d+)\s+/;
            next if !$ip;
-           next if $a =~ /scope\s+link/; # ignore link local
+           next if $addr_line =~ /scope\s+link/; # ignore link local
 
            my $mask = $prefix;