]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
staging: rtl8188eu: core: rtw_xmit: Move constant of the right side
authorGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Wed, 28 Sep 2016 20:33:02 +0000 (23:33 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 2 Oct 2016 15:26:41 +0000 (17:26 +0200)
Constants should be on the right side of comparisons.

Issue found by checkpatch.pl script.

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_xmit.c

index 1d2817b3a5df1345de9397b4ec9f2aba15ba15a0..139289975365e896fa8f8ba03aeece185383440c 100644 (file)
@@ -451,14 +451,14 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
 
        pattrib->pktlen = pktfile.pkt_len;
 
-       if (ETH_P_IP == pattrib->ether_type) {
+       if (pattrib->ether_type == ETH_P_IP) {
                /*  The following is for DHCP and ARP packet, we use cck1M to tx these packets and let LPS awake some time */
                /*  to prevent DHCP protocol fail */
                u8 tmp[24];
                _rtw_pktfile_read(&pktfile, &tmp[0], 24);
                pattrib->dhcp_pkt = 0;
                if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */
-                       if (ETH_P_IP == pattrib->ether_type) {/*  IP header */
+                       if (pattrib->ether_type == ETH_P_IP) {/*  IP header */
                                if (((tmp[21] == 68) && (tmp[23] == 67)) ||
                                    ((tmp[21] == 67) && (tmp[23] == 68))) {
                                        /*  68 : UDP BOOTP client */
@@ -469,7 +469,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
                                }
                        }
                }
-       } else if (0x888e == pattrib->ether_type) {
+       } else if (pattrib->ether_type == 0x888e) {
                DBG_88E_LEVEL(_drv_info_, "send eapol packet\n");
        }