]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
soundwire: remove useless initializations
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 11 Apr 2019 03:16:59 +0000 (22:16 -0500)
committerVinod Koul <vkoul@kernel.org>
Sun, 14 Apr 2019 10:03:26 +0000 (15:33 +0530)
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.

Detected with cppcheck:

[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/bus.c

index 1cbfedfc20efd51700d29b4d2600a76d84d4d98b..6888486370993931cf6184ee01bee90eadeebf83 100644 (file)
@@ -271,8 +271,6 @@ int sdw_fill_msg(struct sdw_msg *msg, struct sdw_slave *slave,
        msg->dev_num = dev_num;
        msg->flags = flags;
        msg->buf = buf;
-       msg->ssp_sync = false;
-       msg->page = false;
 
        if (addr < SDW_REG_NO_PAGE) { /* no paging area */
                return 0;