]> git.proxmox.com Git - mirror_frr.git/commitdiff
doc: add comment on closing PRs
authorLou Berger <lberger@labn.net>
Tue, 28 Aug 2018 21:14:14 +0000 (17:14 -0400)
committerPhilippe Guibert <philippe.guibert@6wind.com>
Wed, 29 Aug 2018 07:48:12 +0000 (09:48 +0200)
Signed-off-by: Lou Berger <lberger@labn.net>
doc/developer/workflow.rst

index 5a88ac8d1fd2b44fa0994df3dfefa972ae2549b5..d316de0f3870143e59bdca9f4b04a7eaba71fe49 100644 (file)
@@ -335,6 +335,11 @@ Guidelines for code review
 - For a PR you marked with "Changes requested", please respond to updates in a
   timely manner to avoid impeding the flow of development.
 
+- Rejected or obsolete PRs are generally closed by the submitter based
+  on requests and/or agreement captured in a PR comment.  The comment
+  may originate with a reviewer or document agreement reached on Slack,
+  the Development mailing list, or the weekly technical meeting.
+
 
 Coding Practices & Style
 ========================