]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
net: remove unneeded break
authorTom Rix <trix@redhat.com>
Mon, 19 Oct 2020 17:26:07 +0000 (10:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Oct 2020 17:28:21 +0000 (10:28 -0700)
A break is not needed if it is preceded by a return or goto

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20201019172607.31622-1-trix@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/aquantia/atlantic/aq_nic.c
drivers/net/ethernet/cisco/enic/enic_ethtool.c
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c
drivers/net/wan/lmc/lmc_proto.c

index 0f865daeb36da433a530f6e07595fbed267376dd..bf5e0e9bd0e2b0c1bbb267537ea035632053862a 100644 (file)
@@ -1163,7 +1163,6 @@ int aq_nic_set_link_ksettings(struct aq_nic_s *self,
                default:
                        err = -1;
                        goto err_exit;
-               break;
                }
                if (!(self->aq_nic_cfg.aq_hw_caps->link_speed_msk & rate)) {
                        err = -1;
index a4dd52bba2c368a2fb27abf428dc8a3a34f868eb..1a9803f2073ef5e3643b37ae2ff096267cc45da7 100644 (file)
@@ -434,7 +434,6 @@ static int enic_grxclsrule(struct enic *enic, struct ethtool_rxnfc *cmd)
                break;
        default:
                return -EINVAL;
-               break;
        }
 
        fsp->h_u.tcp_ip4_spec.ip4src = flow_get_u32_src(&n->keys);
index de563cfd294d49ccbcc98a1fa723930836cb85e6..4b93ba149ec5ceaeb5c7cbad07947a50ffa73ead 100644 (file)
@@ -350,7 +350,6 @@ static s32 ixgbe_calc_eeprom_checksum_X540(struct ixgbe_hw *hw)
                if (ixgbe_read_eerd_generic(hw, pointer, &length)) {
                        hw_dbg(hw, "EEPROM read failed\n");
                        return IXGBE_ERR_EEPROM;
-                       break;
                }
 
                /* Skip pointer section if length is invalid. */
index e8b0b902b42472e1630cf62fb292b93554a29504..4e9cc83b615a9efecd8d2fa1a8227aed0c120425 100644 (file)
@@ -89,17 +89,13 @@ __be16 lmc_proto_type(lmc_softc_t *sc, struct sk_buff *skb) /*FOLD00*/
     switch(sc->if_type){
     case LMC_PPP:
            return hdlc_type_trans(skb, sc->lmc_device);
-           break;
     case LMC_NET:
         return htons(ETH_P_802_2);
-        break;
     case LMC_RAW: /* Packet type for skbuff kind of useless */
         return htons(ETH_P_802_2);
-        break;
     default:
         printk(KERN_WARNING "%s: No protocol set for this interface, assuming 802.2 (which is wrong!!)\n", sc->name);
         return htons(ETH_P_802_2);
-        break;
     }
 }