fix #3894: cast 'size' and 'used' to integer

Perl's automatic conversion can lead to integers being converted to
strings, for example by matching it in a regex.

To make sure we always return an integer in the API call, add an
explicit cast to integer.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>

diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm
index 45b8de836a211f6ea5ddf6787ae7bac855044bff..8ff858d44a544ac29bdeb9ab0c221be2db1615d2 100644 (file)
--- a/PVE/API2/Storage/Content.pm
+++ b/PVE/API2/Storage/Content.pm
@@ -139,7 +139,9 @@ __PACKAGE__->register_method ({
        foreach my $item (@$vollist) {
            eval {  PVE::Storage::check_volume_access($rpcenv, $authuser, $cfg, undef, $item->{volid}); };
            next if $@;
-           $item->{vmid} = int($item->{vmid}) if (defined($item->{vmid}));
+           $item->{vmid} = int($item->{vmid}) if defined($item->{vmid});
+           $item->{size} = int($item->{size}) if defined($item->{size});
+           $item->{used} = int($item->{used}) if defined($item->{used});
            push @$res, $item;
        }
 
@@ -326,8 +328,8 @@ __PACKAGE__->register_method ({
 
        my $entry = {
            path => $path,
-           size => $size,
-            used => $used,
+           size => int($size), # cast to integer in case it was changed to a string previously
+           used => int($used),
            format => $format,
        };