]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
netfilter: ipset: fix boolreturn.cocci warnings
authorWu Fengguang <fengguang.wu@intel.com>
Wed, 11 Feb 2015 12:33:05 +0000 (20:33 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 11 Feb 2015 15:13:30 +0000 (16:13 +0100)
net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool
net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_set.c

index 0d47afea968240623ae4486d56c9a87fe2b7b121..89045982ec9468e01c81f6d86f50d508981e4593 100644 (file)
@@ -193,7 +193,7 @@ set_match_v3(const struct sk_buff *skb, struct xt_action_param *par)
                return ret;
 
        if (!match_counter0(opt.ext.packets, &info->packets))
-               return 0;
+               return false;
        return match_counter0(opt.ext.bytes, &info->bytes);
 }
 
@@ -239,7 +239,7 @@ set_match_v4(const struct sk_buff *skb, struct xt_action_param *par)
                return ret;
 
        if (!match_counter(opt.ext.packets, &info->packets))
-               return 0;
+               return false;
        return match_counter(opt.ext.bytes, &info->bytes);
 }