]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
inet: frags: reorganize struct netns_frags
authorEric Dumazet <edumazet@google.com>
Thu, 13 Sep 2018 14:58:49 +0000 (07:58 -0700)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:48:04 +0000 (19:48 -0600)
BugLink: https://bugs.launchpad.net/bugs/1836117
Put the read-mostly fields in a separate cache line
at the beginning of struct netns_frags, to reduce
false sharing noticed in inet_frag_kill()

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
include/net/inet_frag.h

index a52e7273e7a59bc8ce47b21d29235a740add8db0..ed07e3786d98614898bd5ec9804afb425ba82cec 100644 (file)
@@ -5,16 +5,17 @@
 #include <linux/rhashtable.h>
 
 struct netns_frags {
-       struct rhashtable       rhashtable ____cacheline_aligned_in_smp;
-
-       /* Keep atomic mem on separate cachelines in structs that include it */
-       atomic_long_t           mem ____cacheline_aligned_in_smp;
        /* sysctls */
        long                    high_thresh;
        long                    low_thresh;
        int                     timeout;
        int                     max_dist;
        struct inet_frags       *f;
+
+       struct rhashtable       rhashtable ____cacheline_aligned_in_smp;
+
+       /* Keep atomic mem on separate cachelines in structs that include it */
+       atomic_long_t           mem ____cacheline_aligned_in_smp;
 };
 
 /**