]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: socionext: Fix a signedness bug in ave_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 25 Sep 2019 10:57:50 +0000 (13:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Sep 2019 08:14:14 +0000 (10:14 +0200)
The "phy_mode" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.

Fixes: 4c270b55a5af ("net: ethernet: socionext: add AVE ethernet driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/socionext/sni_ave.c

index 10d0c3e478ab1b5b692a996b9390d8214f3f3c09..d047a53f34f26394abf059c3d6b0e159f0560acf 100644 (file)
@@ -1566,7 +1566,7 @@ static int ave_probe(struct platform_device *pdev)
 
        np = dev->of_node;
        phy_mode = of_get_phy_mode(np);
-       if (phy_mode < 0) {
+       if ((int)phy_mode < 0) {
                dev_err(dev, "phy-mode not found\n");
                return -EINVAL;
        }