]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
igc: Remove unreachable code from igc_phy.c file
authorSasha Neftin <sasha.neftin@intel.com>
Tue, 11 Dec 2018 16:55:41 +0000 (18:55 +0200)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 6 Feb 2019 00:08:54 +0000 (16:08 -0800)
Address community comment.
Remove the unreachable code leads to the static checker warning.
PHY functionality will be added later per demand.
Reported by Dan Carpenter.

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igc/igc_phy.c

index 38e43e6fc1c7c55f3770fd6e7e4809c580095d96..4c8f96a9a148ad7c0166d5478cea7a7674f7923c 100644 (file)
@@ -152,7 +152,6 @@ void igc_power_down_phy_copper(struct igc_hw *hw)
 s32 igc_check_downshift(struct igc_hw *hw)
 {
        struct igc_phy_info *phy = &hw->phy;
-       u16 phy_data, offset, mask;
        s32 ret_val;
 
        switch (phy->type) {
@@ -161,15 +160,8 @@ s32 igc_check_downshift(struct igc_hw *hw)
                /* speed downshift not supported */
                phy->speed_downgraded = false;
                ret_val = 0;
-               goto out;
        }
 
-       ret_val = phy->ops.read_reg(hw, offset, &phy_data);
-
-       if (!ret_val)
-               phy->speed_downgraded = (phy_data & mask) ? true : false;
-
-out:
        return ret_val;
 }