]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
spi: pxa2xx: Remove the shutdown callback
authorLubomir Rintel <lkundrak@v3.sk>
Mon, 17 Sep 2018 12:11:24 +0000 (14:11 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 17 Sep 2018 21:33:57 +0000 (14:33 -0700)
It makes no sense to remove the device on shutdown. And it break things
when the hardware crucial for shutdown (such as the embedded controller)
is attached to the SPI bus.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index e3cbc66a7061b42f7a76fb00b983427c9d84981f..fc9aac214239ad0787a1437d590da018119e7e68 100644 (file)
@@ -1764,14 +1764,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev)
        return 0;
 }
 
-static void pxa2xx_spi_shutdown(struct platform_device *pdev)
-{
-       int status = 0;
-
-       if ((status = pxa2xx_spi_remove(pdev)) != 0)
-               dev_err(&pdev->dev, "shutdown failed with %d\n", status);
-}
-
 #ifdef CONFIG_PM_SLEEP
 static int pxa2xx_spi_suspend(struct device *dev)
 {
@@ -1845,7 +1837,6 @@ static struct platform_driver driver = {
        },
        .probe = pxa2xx_spi_probe,
        .remove = pxa2xx_spi_remove,
-       .shutdown = pxa2xx_spi_shutdown,
 };
 
 static int __init pxa2xx_spi_init(void)