]> git.proxmox.com Git - pve-ha-manager.git/commitdiff
add check for undefined value
authorDietmar Maurer <dietmar@proxmox.com>
Wed, 3 Dec 2014 15:25:04 +0000 (16:25 +0100)
committerDietmar Maurer <dietmar@proxmox.com>
Wed, 3 Dec 2014 15:25:04 +0000 (16:25 +0100)
PVE/HA/Manager.pm

index 2f70406b3efa3a5170506d0e21648012829bff8b..346b70ab07beb6d541a451ebf5ec89416e54b861 100644 (file)
@@ -48,6 +48,7 @@ sub flush_master_status {
     $haenv->write_manager_status($ms);
 } 
 
+# Attention: must be idempotent (alway return the same result for same input!)
 sub select_service_node {
     my ($self, $service_conf) = @_;
 
@@ -149,7 +150,7 @@ sub manage {
                        &$change_service_state($self, $sid, 'request_stop');
                    } elsif ($cd->{state} eq 'enabled') {
                        my $node = $self->select_service_node($cd);
-                       if ($sd->{node} ne $node) {
+                       if ($node && ($sd->{node} ne $node)) {
                            &$change_service_state($self, $sid, 'migrate');
                        } else {
                            # do nothing