]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
wifi: rtw89: Fix some error handling path in rtw89_core_sta_assoc()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 13 Nov 2022 15:49:18 +0000 (16:49 +0100)
committerKalle Valo <kvalo@kernel.org>
Wed, 16 Nov 2022 09:33:33 +0000 (11:33 +0200)
'ret' is not updated after a function call in rtw89_core_sta_assoc().
This prevent error handling from working.

Add the missing assignment.

Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/7b1d82594635e4406d3438f33d8da29eaa056c5a.1668354547.git.christophe.jaillet@wanadoo.fr
drivers/net/wireless/realtek/rtw89/core.c

index e716b96d0f561fc2b371569d7680c468542addec..f30aadc41f2beb33dfb79fcd2fa01b3110db94cb 100644 (file)
@@ -2535,7 +2535,7 @@ int rtw89_core_sta_assoc(struct rtw89_dev *rtwdev,
        }
 
        /* update cam aid mac_id net_type */
-       rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL);
+       ret = rtw89_fw_h2c_cam(rtwdev, rtwvif, rtwsta, NULL);
        if (ret) {
                rtw89_warn(rtwdev, "failed to send h2c cam\n");
                return ret;