]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
qed*: esl priv flag support through ethtool
authorManish Chopra <manishc@marvell.com>
Thu, 2 Dec 2021 21:01:57 +0000 (13:01 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 4 Dec 2021 02:24:21 +0000 (18:24 -0800)
ESL(Enhanced System Lockdown) was designed to lock PCI adapter firmware
images and prevent changes to critical non-volatile configuration data
so that uncontrolled, malicious or unintentional modification to the
adapters are avoided, ensuring it's operational state. Once this feature is
enabled, the device is locked, rejecting any modification to non-volatile
images. Once unlocked, the protection is off such that firmware and
non-volatile configurations may be altered.

Driver just reflects the capability and status of this through
the ethtool private flag.

Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_main.c
drivers/net/ethernet/qlogic/qed/qed_mcp.c
drivers/net/ethernet/qlogic/qed/qed_mcp.h
drivers/net/ethernet/qlogic/qed/qed_mfw_hsi.h
drivers/net/ethernet/qlogic/qede/qede_ethtool.c
include/linux/qed/qed_if.h

index a18d2ea96b26b7cbb113b886d91a47ee981ad82e..46d4207f22a383cd164c36ac2c9b9afa2ea5e57c 100644 (file)
@@ -447,7 +447,7 @@ int qed_fill_dev_info(struct qed_dev *cdev,
                        dev_info->wol_support = true;
 
                dev_info->smart_an = qed_mcp_is_smart_an_supported(p_hwfn);
-
+               dev_info->esl = qed_mcp_is_esl_supported(p_hwfn);
                dev_info->abs_pf_id = QED_LEADING_HWFN(cdev)->abs_pf_id;
        } else {
                qed_vf_get_fw_version(&cdev->hwfns[0], &dev_info->fw_major,
@@ -3028,6 +3028,28 @@ static u8 qed_get_affin_hwfn_idx(struct qed_dev *cdev)
        return QED_AFFIN_HWFN_IDX(cdev);
 }
 
+static int qed_get_esl_status(struct qed_dev *cdev, bool *esl_active)
+{
+       struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
+       struct qed_ptt *ptt;
+       int rc = 0;
+
+       *esl_active = false;
+
+       if (IS_VF(cdev))
+               return 0;
+
+       ptt = qed_ptt_acquire(hwfn);
+       if (!ptt)
+               return -EAGAIN;
+
+       rc = qed_mcp_get_esl_status(hwfn, ptt, esl_active);
+
+       qed_ptt_release(hwfn, ptt);
+
+       return rc;
+}
+
 static struct qed_selftest_ops qed_selftest_ops_pass = {
        .selftest_memory = &qed_selftest_memory,
        .selftest_interrupt = &qed_selftest_interrupt,
@@ -3085,6 +3107,7 @@ const struct qed_common_ops qed_common_ops_pass = {
        .set_grc_config = &qed_set_grc_config,
        .mfw_report = &qed_mfw_report,
        .get_sb_info = &qed_get_sb_info,
+       .get_esl_status = &qed_get_esl_status,
 };
 
 void qed_get_protocol_stats(struct qed_dev *cdev,
index 64678a256f3b3ab43ba21ee9df06ee18dfbb3c64..da1eadabcb419e26abc7a40222dbb22576ff0a88 100644 (file)
@@ -4158,3 +4158,25 @@ qed_mcp_send_raw_debug_data(struct qed_hwfn *p_hwfn,
        return qed_mcp_send_debug_data(p_hwfn, p_ptt,
                                       QED_MCP_DBG_DATA_TYPE_RAW, p_buf, size);
 }
+
+bool qed_mcp_is_esl_supported(struct qed_hwfn *p_hwfn)
+{
+       return !!(p_hwfn->mcp_info->capabilities &
+                 FW_MB_PARAM_FEATURE_SUPPORT_ENHANCED_SYS_LCK);
+}
+
+int qed_mcp_get_esl_status(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, bool *active)
+{
+       u32 resp = 0, param = 0;
+       int rc;
+
+       rc = qed_mcp_cmd(p_hwfn, p_ptt, DRV_MSG_CODE_GET_MANAGEMENT_STATUS, 0, &resp, &param);
+       if (rc) {
+               DP_NOTICE(p_hwfn, "Failed to send ESL command, rc = %d\n", rc);
+               return rc;
+       }
+
+       *active = !!(param & FW_MB_PARAM_MANAGEMENT_STATUS_LOCKDOWN_ENABLED);
+
+       return 0;
+}
index 2c28d5f86497dd105343d9fad70b8d22f416cf13..369e1892450a3283d28d56f845bcf12fea75fa56 100644 (file)
@@ -1339,4 +1339,24 @@ int qed_mcp_nvm_get_cfg(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
 int qed_mcp_nvm_set_cfg(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
                        u16 option_id, u8 entity_id, u16 flags, u8 *p_buf,
                        u32 len);
+
+/**
+ * qed_mcp_is_esl_supported(): Return whether management firmware support ESL or not.
+ *
+ * @p_hwfn: hw function pointer
+ *
+ * Return: true if esl is supported, otherwise return false
+ */
+bool qed_mcp_is_esl_supported(struct qed_hwfn *p_hwfn);
+
+/**
+ * qed_mcp_get_esl_status(): Get enhanced system lockdown status
+ *
+ * @p_hwfn: hw function pointer
+ * @p_ptt: ptt resource pointer
+ * @active: ESL active status data pointer
+ *
+ * Return: 0 with esl status info on success, otherwise return error
+ */
+int qed_mcp_get_esl_status(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, bool *active);
 #endif
index 8a0e3c5d4bda8ef355feb9d14bf0f45095f48299..b70ee8200e15f1d82f4f72ed28e121e5b45e3849 100644 (file)
@@ -1191,6 +1191,7 @@ enum drv_msg_code_enum {
        DRV_MSG_CODE_CFG_VF_MSIX = DRV_MSG_CODE(0xc001),
        DRV_MSG_CODE_CFG_PF_VFS_MSIX = DRV_MSG_CODE(0xc002),
        DRV_MSG_CODE_DEBUG_DATA_SEND = DRV_MSG_CODE(0xc004),
+       DRV_MSG_CODE_GET_MANAGEMENT_STATUS = DRV_MSG_CODE(0xc007),
 };
 
 #define DRV_MSG_CODE_VMAC_TYPE_SHIFT            4
index 100c9c52c20b07dd8edd6b0e489c923240042163..97a7ab0826eded1caf092c5de9312b5788888460 100644 (file)
@@ -168,6 +168,8 @@ enum {
        QEDE_PRI_FLAG_CMT,
        QEDE_PRI_FLAG_SMART_AN_SUPPORT, /* MFW supports SmartAN */
        QEDE_PRI_FLAG_RECOVER_ON_ERROR,
+       QEDE_PRI_FLAG_ESL_SUPPORT, /* MFW supports Enhanced System Lockdown */
+       QEDE_PRI_FLAG_ESL_ACTIVE, /* Enhanced System Lockdown Active status */
        QEDE_PRI_FLAG_LEN,
 };
 
@@ -175,6 +177,8 @@ static const char qede_private_arr[QEDE_PRI_FLAG_LEN][ETH_GSTRING_LEN] = {
        "Coupled-Function",
        "SmartAN capable",
        "Recover on error",
+       "ESL capable",
+       "ESL active",
 };
 
 enum qede_ethtool_tests {
@@ -478,6 +482,7 @@ static int qede_get_sset_count(struct net_device *dev, int stringset)
 static u32 qede_get_priv_flags(struct net_device *dev)
 {
        struct qede_dev *edev = netdev_priv(dev);
+       bool esl_active;
        u32 flags = 0;
 
        if (edev->dev_info.common.num_hwfns > 1)
@@ -489,6 +494,14 @@ static u32 qede_get_priv_flags(struct net_device *dev)
        if (edev->err_flags & BIT(QEDE_ERR_IS_RECOVERABLE))
                flags |= BIT(QEDE_PRI_FLAG_RECOVER_ON_ERROR);
 
+       if (edev->dev_info.common.esl)
+               flags |= BIT(QEDE_PRI_FLAG_ESL_SUPPORT);
+
+       edev->ops->common->get_esl_status(edev->cdev, &esl_active);
+
+       if (esl_active)
+               flags |= BIT(QEDE_PRI_FLAG_ESL_ACTIVE);
+
        return flags;
 }
 
index 9f4bfa2a4829782c6eb173e209a7cdcd3e072671..6dc4943d8aecf3b2feb749ffe278ec70d796b6fe 100644 (file)
@@ -652,6 +652,7 @@ struct qed_dev_info {
 
        bool wol_support;
        bool smart_an;
+       bool esl;
 
        /* MBI version */
        u32 mbi_version;
@@ -1205,6 +1206,8 @@ struct qed_common_ops {
 
        int (*get_sb_info)(struct qed_dev *cdev, struct qed_sb_info *sb,
                           u16 qid, struct qed_sb_info_dbg *sb_dbg);
+
+       int (*get_esl_status)(struct qed_dev *cdev, bool *esl_active);
 };
 
 #define MASK_FIELD(_name, _value) \