]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: fix usage of findRecord
authorDominik Csapak <d.csapak@proxmox.com>
Thu, 26 Nov 2020 08:19:53 +0000 (09:19 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 26 Nov 2020 09:52:07 +0000 (10:52 +0100)
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
www/manager6/dc/Backup.js
www/manager6/dc/SecurityGroups.js
www/manager6/form/ACMEAPISelector.js
www/manager6/form/NodeSelector.js
www/manager6/form/VMCPUFlagSelector.js
www/manager6/form/ViewSelector.js
www/manager6/grid/BackupView.js
www/manager6/grid/FirewallAliases.js
www/manager6/panel/IPSet.js
www/manager6/window/Backup.js

index d868dcfce4f2cbb94e510a59db2680391eba3cf0..059d01c7480da9f793951ef4e843d7b09d8ce11d 100644 (file)
@@ -65,7 +65,7 @@ Ext.define('PVE.dc.BackupEdit', {
            listeners: {
                change: function(f, v) {
                    let store = f.getStore();
-                   let rec = store.findRecord('storage', v);
+                   let rec = store.findRecord('storage', v, 0, false, true, true);
                    let compressionSelector = me.down('pveCompressionSelector');
 
                    if (rec && rec.data && rec.data.type === 'pbs') {
@@ -278,7 +278,7 @@ Ext.define('PVE.dc.BackupEdit', {
                sm.deselectAll(true);
                if (list) {
                    Ext.Array.each(list.split(','), function(vmid) {
-                       var rec = store.findRecord('vmid', vmid);
+                       var rec = store.findRecord('vmid', vmid, 0, false, true, true);
                        if (rec) {
                            sm.select(rec, true);
                        }
index f730721f3c862682edc450e7d2e477ff1e5ad651..90adfa1c3c9c79d7fbff233cb088cf3a51d24036 100644 (file)
@@ -109,7 +109,7 @@ Ext.define('PVE.SecurityGroupList', {
            var oldrec = sm.getSelection()[0];
            store.load(function(records, operation, success) {
                if (oldrec) {
-                   var rec = store.findRecord('group', oldrec.data.group);
+                   var rec = store.findRecord('group', oldrec.data.group, 0, false, true, true);
                    if (rec) {
                        sm.select(rec);
                    }
index 2cf848a1bdf669137c198f9f7f74f74a38654941..9989c21c6e7b167c6e5c79c9867fbacf67295428 100644 (file)
@@ -33,7 +33,7 @@ Ext.define('PVE.form.ACMEApiSelector', {
        let me = this;
        let val = me.getValue();
        if (val) {
-           let record = me.getStore().findRecord('id', val);
+           let record = me.getStore().findRecord('id', val, 0, false, true, true);
            if (record) {
                return record.data.schema;
            }
index a00691eddf95b756fd5cd61b4cbd1c2e20029b66..062869923b5f4997f82c4b7dc1f990ae8a1f159b 100644 (file)
@@ -72,7 +72,7 @@ Ext.define('PVE.form.NodeSelector', {
        var notAllowed = [];
 
        Ext.Array.each(value.split(/\s*,\s*/), function(node) {
-           var rec = me.store.findRecord(me.valueField, node);
+           var rec = me.store.findRecord(me.valueField, node, 0, false, true, true);
            if (!(rec && rec.data) || rec.data.status !== 'online') {
                offline.push(node);
            } else if (me.allowedNodes && !Ext.Array.contains(me.allowedNodes, node)) {
index 7b435d45ca1fa8aa738d52150d97bf10ea7c4638..71aa7ad7341849de64faa958403f06c52e46edeb 100644 (file)
@@ -81,7 +81,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
            var sign = flag.substr(0, 1);
            flag = flag.substr(1);
 
-           var rec = store.findRecord('flag', flag);
+           var rec = store.findRecord('flag', flag, 0, false, true, true);
            if (rec !== null) {
                rec.set('state', sign);
            } else {
index e075be1a09e391e32f87b644e2369b22e304aa48..025fcfac88d067e6e17e122ed257abbfe4d34893 100644 (file)
@@ -74,7 +74,7 @@ Ext.define('PVE.form.ViewSelector', {
            applyState : function(state, doSelect) {
                var view = me.getValue();
                if (state && state.value && (view != state.value)) {
-                   var record = store.findRecord('key', state.value);
+                   var record = store.findRecord('key', state.value, 0, false, true, true);
                    if (record) {
                        me.setValue(state.value, true);
                        if (doSelect) {
index d04baeefd2ea6cfaf309e6d89c469d0effa01432..9312c59c22dbf356fde397f501fd4e26735b38bd 100644 (file)
@@ -99,7 +99,7 @@ Ext.define('PVE.grid.BackupView', {
            allowBlank: false,
            listeners: {
                change: function(f, value) {
-                   let storage = f.getStore().findRecord('storage', value);
+                   let storage = f.getStore().findRecord('storage', value, 0, false, true, true);
                    if (storage) {
                        let isPBS = storage.data.type === 'pbs';
                        me.getColumns().forEach((column) => {
@@ -241,7 +241,9 @@ Ext.define('PVE.grid.BackupView', {
                        disabled: true,
                        enableFn: function() {
                            let storageVal = storagesel.getValue();
-                           let storage = storagesel.getStore().findRecord('storage', storageVal);
+                           let storage = storagesel
+                               .getStore()
+                               .findRecord('storage', storageVal, 0, false, true, true);
                            if (storage) {
                                return storage.data.type !== 'pbs';
                            }
index 807327262414d0cce30fd81f74508871de04aab9..40bfe35712584da9bd406bd782af273856c9de76 100644 (file)
@@ -112,7 +112,7 @@ Ext.define('PVE.FirewallAliases', {
            var oldrec = sm.getSelection()[0];
            store.load(function(records, operation, success) {
                if (oldrec) {
-                   var rec = store.findRecord('name', oldrec.data.name);
+                   var rec = store.findRecord('name', oldrec.data.name, 0, false, true, true);
                    if (rec) {
                        sm.select(rec);
                    }
index ed99586a2a36fde32012eb99ebea3d6a9ecab17c..f8f8c1c6010b986c166dd0ef9ce31004ca48e02c 100644 (file)
@@ -49,7 +49,7 @@ Ext.define('PVE.IPSetList', {
            var oldrec = sm.getSelection()[0];
            store.load(function(records, operation, success) {
                if (oldrec) {
-                   var rec = store.findRecord('name', oldrec.data.name);
+                   var rec = store.findRecord('name', oldrec.data.name, 0, false, true, true);
                    if (rec) {
                        sm.select(rec);
                    }
index 55f52676a7fb6ea9b3b233da4cdeed6b46e4ef8a..f50e4f30a8f9ce0ffb24c9251690b6b44a3a76ec 100644 (file)
@@ -33,7 +33,7 @@ Ext.define('PVE.window.Backup', {
            listeners: {
                change: function(f, v) {
                    let store = f.getStore();
-                   let rec = store.findRecord('storage', v);
+                   let rec = store.findRecord('storage', v, 0, false, true, true);
 
                    if (rec && rec.data && rec.data.type === 'pbs') {
                        compressionSelector.setValue('zstd');