USB: host: sl811: remove dentry pointer for debugfs

There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.

Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210216144645.3813043-3-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 115ced0d93e101854e259e73cb7dc5608ad53869..d49fb656d34b8f72e0dd81b58b14a4b5635355e3 100644 (file)
--- a/drivers/usb/host/sl811-hcd.c
+++ b/drivers/usb/host/sl811-hcd.c
@@ -1496,14 +1496,13 @@ DEFINE_SHOW_ATTRIBUTE(sl811h_debug);
 /* expect just one sl811 per system */
 static void create_debug_file(struct sl811 *sl811)
 {
-       sl811->debug_file = debugfs_create_file("sl811h", S_IRUGO,
-                                               usb_debug_root, sl811,
-                                               &sl811h_debug_fops);
+       debugfs_create_file("sl811h", S_IRUGO, usb_debug_root, sl811,
+                           &sl811h_debug_fops);
 }
 
 static void remove_debug_file(struct sl811 *sl811)
 {
-       debugfs_remove(sl811->debug_file);
+       debugfs_remove(debugfs_lookup("sl811h", usb_debug_root));
 }
 
 /*-------------------------------------------------------------------------*/

diff --git a/drivers/usb/host/sl811.h b/drivers/usb/host/sl811.h
index 2abe51a5db4452517ae328f64c7f5dae28eb728a..ba8c9aa7dee852586aac7270b19359b36b9786da 100644 (file)
--- a/drivers/usb/host/sl811.h
+++ b/drivers/usb/host/sl811.h
@@ -123,7 +123,6 @@ struct sl811 {
        void __iomem            *addr_reg;
        void __iomem            *data_reg;
        struct sl811_platform_data      *board;
-       struct dentry           *debug_file;
 
        unsigned long           stat_insrmv;
        unsigned long           stat_wake;