ofp-flow: Fix uninitialized data decoding OF1.5 flow stats.

Reported-by: Paul Greenberg
Reported-at: https://github.com/openvswitch/ovs-issues/issues/149
Fixes: c7b02b800615 ("Add support for OpenFlow 1.5 statistics (OXS).")
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Darrell Ball <dlu998@gmail.com>

diff --git a/AUTHORS.rst b/AUTHORS.rst
index c93d5be5f72ced14f40fe51f1ca257a6a04f4396..9c81ad8b5d2db878a5076d38a7468a6c12e986c4 100644 (file)
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -533,6 +533,7 @@ Niklas Andersson                nandersson@nicira.com
 Pankaj Thakkar                  thakkar@nicira.com
 Pasi Kärkkäinen                 pasik@iki.fi
 Patrik Andersson R              patrik.r.andersson@ericsson.com
+Paul Greenberg
 Paulo Cravero                   pcravero@as2594.net
 Pawan Shukla                    shuklap@vmware.com
 Periyasamy Palanisamy           periyasamy.palanisamy@ericsson.com

diff --git a/lib/ofp-flow.c b/lib/ofp-flow.c
index 9fbe8c2e5cb297196ffb5bd4e0085e499fb29225..4b893ce959d4efc17126dcdf5a9b4c04912c94d6 100644 (file)
--- a/lib/ofp-flow.c
+++ b/lib/ofp-flow.c
@@ -955,6 +955,7 @@ ofputil_decode_flow_stats_reply(struct ofputil_flow_stats *fs,
         fs->packet_count = oxs.packet_count;
         fs->byte_count = oxs.byte_count;
         fs->idle_age = oxs.idle_age == UINT32_MAX ? -1 : oxs.idle_age;
+        fs->hard_age = -1;
 
         instructions_len = length - sizeof *ofd - padded_match_len - stat_len;
     } else if (raw == OFPRAW_OFPST11_FLOW_REPLY