]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
io_uring: remove redundant assignment to ret in io_register_iowq_max_workers()
authorNghia Le <nghialm78@gmail.com>
Tue, 2 Nov 2021 19:05:21 +0000 (02:05 +0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 2 Nov 2021 20:29:12 +0000 (14:29 -0600)
After the assignment, only exit path with label 'err' uses ret as
return value. However,before exiting through this path with label 'err',
ret is assigned with the return value of io_wq_max_workers(). Hence, the
initial assignment is redundant and can be removed.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
Link: https://lore.kernel.org/r/20211102190521.28291-1-nghialm78@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 61c962c29235f6e4a14ae3f649925ec91b3ef85a..1c8602f12c911a9388910509207cf24d8a0c9da4 100644 (file)
@@ -10794,7 +10794,6 @@ static __cold int io_register_iowq_max_workers(struct io_ring_ctx *ctx,
        memcpy(ctx->iowq_limits, new_count, sizeof(new_count));
        ctx->iowq_limits_set = true;
 
-       ret = -EINVAL;
        if (tctx && tctx->io_wq) {
                ret = io_wq_max_workers(tctx->io_wq, new_count);
                if (ret)