]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
[media] em28xx: disable ioctl VIDIOC_S_PARM for VBI devices
authorFrank Schaefer <fschaefer.oss@googlemail.com>
Thu, 7 Feb 2013 16:39:13 +0000 (13:39 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 4 Mar 2013 16:40:09 +0000 (13:40 -0300)
VIDIOC_S_PARM doesn't make sense for VBI device nodes, because we don't support
selecting the number of read buffers to use.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/em28xx/em28xx-video.c

index 2f7c5abad75ee727808888bc761da3ad14916f19..c1f6c59f53aac0b9ea9f9233ca913103a6d45eab 100644 (file)
@@ -1920,6 +1920,7 @@ int em28xx_register_analog_devices(struct em28xx *dev)
                dev->vbi_dev->queue->lock = &dev->vb_vbi_queue_lock;
 
                /* disable inapplicable ioctls */
+               v4l2_disable_ioctl(dev->vdev, VIDIOC_S_PARM);
                if (dev->tuner_type == TUNER_ABSENT) {
                        v4l2_disable_ioctl(dev->vbi_dev, VIDIOC_G_TUNER);
                        v4l2_disable_ioctl(dev->vbi_dev, VIDIOC_S_TUNER);