]> git.proxmox.com Git - mirror_frr.git/commitdiff
Fix: reverse logic of when to pass the supplied group address
authorJafar Al-Gharaibeh <jafar@atcorp.com>
Tue, 2 May 2017 17:15:06 +0000 (12:15 -0500)
committerJafar Al-Gharaibeh <jafar@atcorp.com>
Tue, 2 May 2017 17:15:06 +0000 (12:15 -0500)
   This was causing a crash when no group address was passed
   because a garbage pointer valuse was used. It also was ignoring
   the group address when passing one.

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>
pimd/pim_cmd.c

index e7910ade3c8f65c955e92b2df36fa4646d1e2048..55970987e9a01f5f39cdbe4a2a7a693bf0d615f4 100644 (file)
@@ -3747,9 +3747,10 @@ DEFUN (ip_pim_rp,
   int idx_ipv4 = 3;
 
   if (argc == (idx_ipv4 + 1))
-    return pim_rp_cmd_worker (vty, argv[idx_ipv4]->arg, argv[idx_ipv4 + 1]->arg, NULL);
-  else
     return pim_rp_cmd_worker (vty, argv[idx_ipv4]->arg, NULL, NULL);
+  else
+    return pim_rp_cmd_worker (vty, argv[idx_ipv4]->arg, argv[idx_ipv4 + 1]->arg, NULL);
+
 }
 
 DEFUN (ip_pim_rp_prefix_list,
@@ -3805,9 +3806,9 @@ DEFUN (no_ip_pim_rp,
   int idx_ipv4 = 4;
 
   if (argc == (idx_ipv4 + 1))
-    return pim_no_rp_cmd_worker (vty, argv[idx_ipv4]->arg, argv[idx_ipv4 + 1]->arg, NULL);
-  else
     return pim_no_rp_cmd_worker (vty, argv[idx_ipv4]->arg, NULL, NULL);
+  else
+    return pim_no_rp_cmd_worker (vty, argv[idx_ipv4]->arg, argv[idx_ipv4 + 1]->arg, NULL);
 }
 
 DEFUN (no_ip_pim_rp_prefix_list,