]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
mips: mm: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 14:57:40 +0000 (15:57 +0100)
committerPaul Burton <paul.burton@mips.com>
Tue, 22 Jan 2019 19:17:20 +0000 (11:17 -0800)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mips@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>
arch/mips/mm/sc-debugfs.c

index 2a116084216f2ca7cea3541d85b45a3663f3a5a6..9507421de3351b89cbc09aa229ee8fc2e15b24be 100644 (file)
@@ -55,20 +55,11 @@ static const struct file_operations sc_prefetch_fops = {
 
 static int __init sc_debugfs_init(void)
 {
-       struct dentry *dir, *file;
-
-       if (!mips_debugfs_dir)
-               return -ENODEV;
+       struct dentry *dir;
 
        dir = debugfs_create_dir("l2cache", mips_debugfs_dir);
-       if (IS_ERR(dir))
-               return PTR_ERR(dir);
-
-       file = debugfs_create_file("prefetch", S_IRUGO | S_IWUSR, dir,
-                                  NULL, &sc_prefetch_fops);
-       if (!file)
-               return -ENOMEM;
-
+       debugfs_create_file("prefetch", S_IRUGO | S_IWUSR, dir, NULL,
+                           &sc_prefetch_fops);
        return 0;
 }
 late_initcall(sc_debugfs_init);