]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
gpio: mvebu: Make use of for_each_requested_gpio()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 15 Jun 2020 15:05:43 +0000 (18:05 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 20 Jun 2020 21:13:27 +0000 (23:13 +0200)
Make use of for_each_requested_gpio() instead of home grown analogue.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200615150545.87964-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mvebu.c

index bd65114eb17048c40ed43cc6bbe3e6157149c2b1..433e2c3f3fd5d1dd20d8955d8db198775216052d 100644 (file)
@@ -846,6 +846,7 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 {
        struct mvebu_gpio_chip *mvchip = gpiochip_get_data(chip);
        u32 out, io_conf, blink, in_pol, data_in, cause, edg_msk, lvl_msk;
+       const char *label;
        int i;
 
        regmap_read(mvchip->regs, GPIO_OUT_OFF + mvchip->offset, &out);
@@ -857,15 +858,10 @@ static void mvebu_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
        edg_msk = mvebu_gpio_read_edge_mask(mvchip);
        lvl_msk = mvebu_gpio_read_level_mask(mvchip);
 
-       for (i = 0; i < chip->ngpio; i++) {
-               const char *label;
+       for_each_requested_gpio(chip, i, label) {
                u32 msk;
                bool is_out;
 
-               label = gpiochip_is_requested(chip, i);
-               if (!label)
-                       continue;
-
                msk = BIT(i);
                is_out = !(io_conf & msk);