]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
drm/omap: Fix error handling path in 'omap_dmm_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 24 Sep 2017 06:01:03 +0000 (08:01 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 30 Nov 2017 10:25:37 +0000 (12:25 +0200)
If we don't find a matching device node, we must free the memory allocated
in 'omap_dmm' a few lines above.

Fixes: 7cb0d6c17b96 ("drm/omap: fix TILER on OMAP5")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c

index 1dd3dafc59afd25b5048ac105eb7627bafb16c9a..c60a85e82c6d8a529aa40062fdde21354d73b505 100644 (file)
@@ -638,7 +638,8 @@ static int omap_dmm_probe(struct platform_device *dev)
                match = of_match_node(dmm_of_match, dev->dev.of_node);
                if (!match) {
                        dev_err(&dev->dev, "failed to find matching device node\n");
-                       return -ENODEV;
+                       ret = -ENODEV;
+                       goto fail;
                }
 
                omap_dmm->plat_data = match->data;