foreach_mountpoint_full($conf, 1, $func);
}
-sub blockdevices_list {
-
- my $bdevs = {};
- dir_glob_foreach("/sys/dev/block/", '(\d+):(\d+)', sub {
- my (undef, $major, $minor) = @_;
- my $bdev = readlink("/sys/dev/block/$major:$minor");
- $bdev =~ s/\.\.\/\.\.\/devices\/virtual\/block\//\/dev\//;
- $bdevs->{$bdev}->{major} = $major;
- $bdevs->{$bdev}->{minor} = $minor;
- });
- return $bdevs;
-}
-
sub check_ct_modify_config_perm {
my ($rpcenv, $authuser, $vmid, $pool, $key_list) = @_;
use POSIX;
use File::Path;
+use Fcntl ':mode';
use PVE::SafeSyslog;
use PVE::Tools;
$raw = -f $fn ? PVE::Tools::file_get_contents($fn) : '';
my $storage_cfg = PVE::Storage::Plugin->parse_config($fn, $raw);
- my $bdevs = PVE::LXC::blockdevices_list();
-
my $setup_mountpoint = sub {
my ($ms, $mountpoint) = @_;
my ($ms, $mountpoint) = @_;
my $volid = $mountpoint->{volume};
- return if !$volid || $volid =~ m|^/dev/.+|;
+ return if !$volid || $volid !~ m|^/dev/.+|;
my $path = PVE::LXC::mountpoint_mount_path($mountpoint, $storage_cfg);
- if (-l $path) {
- $path = readlink($path);
- $path =~ s/\.\.\/\.\.\//\/dev\//;
- }
-
- if ($bdevs->{$path}) {
- PVE::Tools::run_command(['mknod', '-m', '666', "$rootdir$path", 'b', $bdevs->{$path}->{major}, $bdevs->{$path}->{minor}]);
- PVE::LXC::write_cgroup_value("devices", $vmid, "devices.allow", "b $bdevs->{$path}->{major}:$bdevs->{$path}->{minor} rwm");
+ my (undef, undef, $mode, undef, undef, undef, $rdev) = stat($path);
+ if ($mode && S_ISBLK($mode) && $rdev) {
+ my $major = int($rdev / 0x100);
+ my $minor = $rdev % 0x100;
+ if ($major != 7) { # must not be a loop device
+ PVE::Tools::run_command(['mknod', '-m', '666', "$rootdir$path", 'b', $major, $minor]);
+ PVE::LXC::write_cgroup_value("devices", $vmid, "devices.allow", "b ${major}:${minor} rwm");
+ }
}
};