]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
rsi: Add null check for virtual interfaces in wowlan config
authorSanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
Fri, 11 May 2018 14:57:51 +0000 (20:27 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:21:05 +0000 (14:21 +0100)
BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit 54b5172087aeae61150835c91e68f084a9644f1c ]

When the "poweroff" command is executed after wowlan enabled, we have
observed a system crash. In the system "poweroff" sequence, network-manager
is sent to inactive state by cleaning up the network interfaces, using
rsi_mac80211_remove_interface() and when driver tries to access those
network interfaces in rsi_wowlan_config() which was invoked by SDIO
shutdown, results in a crash. Added a NULL check before accessing the
network interfaces in rsi_wowlan_config().

Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/wireless/rsi/rsi_91x_mac80211.c

index 32f5cb46fd4f4dc2417098bde4bd041a781994da..8f83303365c8b87e6f1ea525be9026a8b0f90660 100644 (file)
@@ -1788,10 +1788,15 @@ int rsi_config_wowlan(struct rsi_hw *adapter, struct cfg80211_wowlan *wowlan)
        struct rsi_common *common = adapter->priv;
        u16 triggers = 0;
        u16 rx_filter_word = 0;
-       struct ieee80211_bss_conf *bss = &adapter->vifs[0]->bss_conf;
+       struct ieee80211_bss_conf *bss = NULL;
 
        rsi_dbg(INFO_ZONE, "Config WoWLAN to device\n");
 
+       if (!adapter->vifs[0])
+               return -EINVAL;
+
+       bss = &adapter->vifs[0]->bss_conf;
+
        if (WARN_ON(!wowlan)) {
                rsi_dbg(ERR_ZONE, "WoW triggers not enabled\n");
                return -EINVAL;