]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
isdn: hisax: callc: Replace GFP_ATOMIC with GFP_KERNEL in init_PStack()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 02:45:30 +0000 (10:45 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 04:23:16 +0000 (21:23 -0700)
init_PStack() is never called in atomic context.
It calls kmalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/callc.c

index 5f43783039d4617dcf5e328435192a3beed235fa..9ee06328784c59f8e6eec67b64873b22f9b46fbb 100644 (file)
@@ -1012,7 +1012,7 @@ dummy_pstack(struct PStack *st, int pr, void *arg) {
 
 static int
 init_PStack(struct PStack **stp) {
-       *stp = kmalloc(sizeof(struct PStack), GFP_ATOMIC);
+       *stp = kmalloc(sizeof(struct PStack), GFP_KERNEL);
        if (!*stp)
                return -ENOMEM;
        (*stp)->next = NULL;