]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
perf tools: Just pr_debug() about not being able to read cacheline_size
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 15 Jul 2016 13:05:19 +0000 (10:05 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 15 Jul 2016 13:08:29 +0000 (10:08 -0300)
So far the cacheline_size is only useful for the "dcacheline" --sort
order, i.e. if that is not used, which is the norm, then the user
shouldn't care that he is running this, say, on an Android system where
sysconf(_SC_LEVEL1_DCACHE_LINESIZE) and the
/sys/devices/system/cpu/cpu0/cache/index0/coherency_line_size sysfs file
isn't available.

An upcoming patch will emit an warning only for "--sort ...,dcacheline,...".

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chris Phlipot <cphlipot0@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-580cnkvftunyvt9n7unsholi@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/perf.c

index 4b2ff021434c29a35450d03c4c610a59c319884e..64c06961bfe495341c954ffced4aa5e06d5e380e 100644 (file)
@@ -503,7 +503,7 @@ void pthread__unblock_sigwinch(void)
 static void cache_line_size(int *cacheline_sizep)
 {
        if (sysfs__read_int("devices/system/cpu/cpu0/cache/index0/coherency_line_size", cacheline_sizep))
-               perror("cannot determine cache line size");
+               pr_debug("cannot determine cache line size");
 }
 #endif