]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
vhost-scsi: remove incorrect memory barrier
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 16 Apr 2019 08:56:08 +0000 (10:56 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 12 May 2019 17:11:35 +0000 (13:11 -0400)
At this point, vs_tpg is not public at all; tv_tpg_vhost_count
is accessed under tpg->tv_tpg_mutex; tpg->vhost_scsi is
accessed under vhost_scsi_mutex.  Therefor there are no atomic
operations involved at all here, just remove the barrier.

Reported-by: Andrea Parri <andrea.parri@amarulasolutions.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
drivers/vhost/scsi.c

index 618fb646101768ebfb5ddd71166d6420d42e3caa..c090d177bd75cf2c006b39d848038806748040a4 100644 (file)
@@ -1443,7 +1443,6 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
                        tpg->tv_tpg_vhost_count++;
                        tpg->vhost_scsi = vs;
                        vs_tpg[tpg->tport_tpgt] = tpg;
-                       smp_mb__after_atomic();
                        match = true;
                }
                mutex_unlock(&tpg->tv_tpg_mutex);