]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: lpc-enet: fix error return code in lpc_mii_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 27 Apr 2020 12:15:07 +0000 (12:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 03:29:39 +0000 (20:29 -0700)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/nxp/lpc_eth.c

index d20cf03a3ea0c365b756eb4b58161990de446d1a..311454d9b0bcce73439d35365414646f744bd8f5 100644 (file)
@@ -823,7 +823,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
        if (err)
                goto err_out_unregister_bus;
 
-       if (lpc_mii_probe(pldat->ndev) != 0)
+       err = lpc_mii_probe(pldat->ndev);
+       if (err)
                goto err_out_unregister_bus;
 
        return 0;