do not allow deletion of ha group if group is used

diff --git a/changelog.Debian b/changelog.Debian
index 08fc1436831cf16b53f22cf7f3ed9552b3cc36cb..3c39a1f9506fff6ff47ba5d8b6bc6d4c65bc4a3d 100644 (file)
--- a/changelog.Debian
+++ b/changelog.Debian
@@ -6,6 +6,8 @@ pve-ha-manager (0.9-1) unstable; urgency=medium
 
   * allow to use simply VMIDs as resource id
 
+  * finalize ha api
+
  -- Proxmox Support Team <support@proxmox.com>  Fri, 03 Apr 2015 06:18:05 +0200
 
 pve-ha-manager (0.8-2) unstable; urgency=medium

diff --git a/src/PVE/API2/HA/Groups.pm b/src/PVE/API2/HA/Groups.pm
index a5eefa459fd4ae824d017bf0e510d66d9b892e0b..65f88a656be837b8969e400fc93a035e09d8d872 100644 (file)
--- a/src/PVE/API2/HA/Groups.pm
+++ b/src/PVE/API2/HA/Groups.pm
@@ -206,9 +206,16 @@ __PACKAGE__->register_method ({
 
        my $group = extract_param($param, 'group');
 
-       PVE::HA::Config::lock_ha_config(
+       PVE::HA::Config::lock_ha_config(
            sub {
 
+               my $rcfg = PVE::HA::Config::read_resources_config();
+               foreach my $sid (keys %$rcfg->{ids}) {
+                   my $sg = $rcfg->{ids}->{$sid}->{group};
+                   die "ha group is used by service '$sid'\n" 
+                       if ($sg && $sg eq $group);
+               }
+
                my $cfg = PVE::HA::Config::read_group_config();
 
                delete $cfg->{ids}->{$group};