octeontx2-pf: mcs: fix missing unlock in some error paths

Add the missing unlock in some error paths.

Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
index 18420d9a145fb19319ee37941566b7440b02517b..9809f551fc2e3db0176f9115b78fc20be4539e9e 100644 (file)
--- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c
@@ -284,7 +284,7 @@ static int cn10k_mcs_write_sc_cam(struct otx2_nic *pfvf,
 
        sc_req = otx2_mbox_alloc_msg_mcs_rx_sc_cam_write(mbox);
        if (!sc_req) {
-               return -ENOMEM;
+               ret = -ENOMEM;
                goto fail;
        }
 
@@ -594,7 +594,7 @@ static int cn10k_mcs_ena_dis_flowid(struct otx2_nic *pfvf, u16 hw_flow_id,
 
        req = otx2_mbox_alloc_msg_mcs_flowid_ena_entry(mbox);
        if (!req) {
-               return -ENOMEM;
+               ret = -ENOMEM;
                goto fail;
        }
 
@@ -1653,6 +1653,7 @@ int cn10k_mcs_init(struct otx2_nic *pfvf)
        return 0;
 fail:
        dev_err(pfvf->dev, "Cannot notify PN wrapped event\n");
+       mutex_unlock(&mbox->lock);
        return 0;
 }