]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
e1000: switch to napi_build_skb()
authorAlexander Lobakin <alexandr.lobakin@intel.com>
Tue, 23 Nov 2021 17:18:33 +0000 (18:18 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 28 Dec 2021 17:42:25 +0000 (09:42 -0800)
napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order
to save some cycles on freeing/allocating skbuff_heads on every
new Rx or completed Tx element.
e1000 driver runs Tx completion polling cycle right before the Rx
one. Now that e1000 uses napi_consume_skb() to put skbuff_heads of
completed entries into the cache, it will never empty and always
warm at that moment. Switch to the napi_build_skb() to relax mm
pressure on heavy Rx and increase throughput.

Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Tested-by: Tony Brelinski <tony.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e1000/e1000_main.c

index 975a145d48efff5caa4e5ad3b680205a1f86adae..3f5feb55cfbaae03ffb233b7e1341e426d1b7f08 100644 (file)
@@ -4384,7 +4384,7 @@ static bool e1000_clean_rx_irq(struct e1000_adapter *adapter,
                if (!skb) {
                        unsigned int frag_len = e1000_frag_len(adapter);
 
-                       skb = build_skb(data - E1000_HEADROOM, frag_len);
+                       skb = napi_build_skb(data - E1000_HEADROOM, frag_len);
                        if (!skb) {
                                adapter->alloc_rx_buff_failed++;
                                break;