]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
hv_netvsc: Use the num_online_cpus() for channel limit
authorHaiyang Zhang <haiyangz@microsoft.com>
Mon, 14 May 2018 22:32:08 +0000 (15:32 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:28:00 +0000 (12:28 +0200)
BugLink: http://bugs.launchpad.net/bugs/1783418
[ Commit 25a39f7f975c3c26a0052fbf9b59201c06744332 upstream. ]

Since we no longer localize channel/CPU affiliation within one NUMA
node, num_online_cpus() is used as the number of channel cap, instead of
the number of processors in a NUMA node.

This patch allows a bigger range for tuning the number of channels.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/hyperv/rndis_filter.c

index 07ce3710881de337a557ce4564ed64d2a229c059..2536383f3cf12a3d8bec59e3ad27c5ffbcaae737 100644 (file)
@@ -1221,7 +1221,6 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
        struct ndis_recv_scale_cap rsscap;
        u32 rsscap_size = sizeof(struct ndis_recv_scale_cap);
        u32 mtu, size;
-       const struct cpumask *node_cpu_mask;
        u32 num_possible_rss_qs;
        int i, ret;
 
@@ -1290,14 +1289,8 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev,
        if (ret || rsscap.num_recv_que < 2)
                goto out;
 
-       /*
-        * We will limit the VRSS channels to the number CPUs in the NUMA node
-        * the primary channel is currently bound to.
-        *
-        * This also guarantees that num_possible_rss_qs <= num_online_cpus
-        */
-       node_cpu_mask = cpumask_of_node(cpu_to_node(dev->channel->target_cpu));
-       num_possible_rss_qs = min_t(u32, cpumask_weight(node_cpu_mask),
+       /* This guarantees that num_possible_rss_qs <= num_online_cpus */
+       num_possible_rss_qs = min_t(u32, num_online_cpus(),
                                    rsscap.num_recv_que);
 
        net_device->max_chn = min_t(u32, VRSS_CHANNEL_MAX, num_possible_rss_qs);