]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ASoC: atmel: Add missing of_node_put() in at91sam9g20ek_audio_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 12:45:39 +0000 (12:45 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:18:45 +0000 (15:18 +0200)
BugLink: https://bugs.launchpad.net/bugs/1971497
[ Upstream commit f590797fa3c1bccdd19e55441592a23b46aef449 ]

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function.
Calling of_node_put() to avoid the refcount leak.

Fixes: 531f67e41dcd ("ASoC: at91sam9g20ek-wm8731: convert to dt support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Link: https://lore.kernel.org/r/20220307124539.1743-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/atmel/sam9g20_wm8731.c

index b1bef2bf142dc1e392b284f262f08933f1346a65..05277a88e20d8ee32794e290ad2e04fb7588d5a4 100644 (file)
@@ -214,6 +214,7 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
        cpu_np = of_parse_phandle(np, "atmel,ssc-controller", 0);
        if (!cpu_np) {
                dev_err(&pdev->dev, "dai and pcm info missing\n");
+               of_node_put(codec_np);
                return -EINVAL;
        }
        at91sam9g20ek_dai.cpus->of_node = cpu_np;