]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
openvswitch: checking wrong variable in queue_userspace_packet()
authorDan Carpenter <dan.carpenter@oracle.com>
Sun, 13 May 2012 08:44:18 +0000 (08:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 May 2012 19:47:34 +0000 (15:47 -0400)
"skb" is non-NULL here, for example we dereference it in skb_clone().
The intent was to test "nskb" which was just set.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jesse Gross <jesse@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/datapath.c

index 777716bc80f7c2ad183a7309c037f4cc9c84fffa..e66341ec455c3d7c588680bd829e044b7d7752ce 100644 (file)
@@ -321,7 +321,7 @@ static int queue_userspace_packet(int dp_ifindex, struct sk_buff *skb,
                        return -ENOMEM;
 
                nskb = __vlan_put_tag(nskb, vlan_tx_tag_get(nskb));
-               if (!skb)
+               if (!nskb)
                        return -ENOMEM;
 
                nskb->vlan_tci = 0;