]> git.proxmox.com Git - mirror_qemu.git/commitdiff
get_maintainer.pl: move git loop under "if ($email) {"
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 22 Oct 2014 08:38:27 +0000 (10:38 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 23 Oct 2014 14:41:27 +0000 (16:41 +0200)
All checks in the loop are guarded by that condition, and there is a
handy "if" just below.  Simplify the code.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
scripts/get_maintainer.pl

index 38334de8751f6e10291b19e10a25a7ffa1f55419..906dcbe468a931c7ce521516731f7e4b66101b45 100755 (executable)
@@ -651,18 +651,17 @@ sub get_maintainers {
        $email->[0] = deduplicate_email($email->[0]);
     }
 
-    foreach my $file (@files) {
-       if ($email &&
-           ($email_git || ($email_git_fallback &&
-                           !$exact_pattern_match_hash{$file}))) {
-           vcs_file_signoffs($file);
-       }
-       if ($email && $email_git_blame) {
-           vcs_file_blame($file);
+    if ($email) {
+       foreach my $file (@files) {
+           if ($email_git || ($email_git_fallback &&
+                              !$exact_pattern_match_hash{$file})) {
+               vcs_file_signoffs($file);
+           }
+           if ($email_git_blame) {
+               vcs_file_blame($file);
+           }
        }
-    }
 
-    if ($email) {
        foreach my $chief (@penguin_chief) {
            if ($chief =~ m/^(.*):(.*)/) {
                my $email_address;