]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ipvs: initialize tbl->entries in ip_vs_lblc_init_svc()
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 23 Apr 2018 21:04:45 +0000 (14:04 -0700)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 26 Apr 2018 22:20:33 +0000 (00:20 +0200)
Similarly, tbl->entries is not initialized after kmalloc(),
therefore causes an uninit-value warning in ip_vs_lblc_check_expire(),
as reported by syzbot.

Reported-by: <syzbot+3e9695f147fb529aa9bc@syzkaller.appspotmail.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipvs/ip_vs_lblc.c

index 08147fc6400ccf65ca7b8688826aaba1f3fa85c5..b9f375e6dc937d2979074365118ecd11d662c282 100644 (file)
@@ -372,6 +372,7 @@ static int ip_vs_lblc_init_svc(struct ip_vs_service *svc)
        tbl->counter = 1;
        tbl->dead = false;
        tbl->svc = svc;
+       atomic_set(&tbl->entries, 0);
 
        /*
         *    Hook periodic timer for garbage collection