md: md_clear_badblocks should return an error code on failure.

Julia Lawall and coccinelle report that md_clear_badblocks always
returns 0, despite appearing to have an error path.
The error path really should return an error code.  ENOSPC is
reasonably appropriate.

Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 0ddf38988fbc89b5b23225e3394d322e67850b7c..34846856dbc6106c95b81d948a4e41ad6e4d816d 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8343,7 +8343,7 @@ static int md_clear_badblocks(struct badblocks *bb, sector_t s, int sectors)
                        if (a < s) {
                                /* we need to split this range */
                                if (bb->count >= MD_MAX_BADBLOCKS) {
-                                       rv = 0;
+                                       rv = -ENOSPC;
                                        goto out;
                                }
                                memmove(p+lo+1, p+lo, (bb->count - lo) * 8);