]> git.proxmox.com Git - mirror_qemu.git/commitdiff
tpm: Avoid qerror_report() outside QMP command handlers
authorMarkus Armbruster <armbru@redhat.com>
Tue, 17 Mar 2015 11:09:02 +0000 (12:09 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 22 Jun 2015 16:20:40 +0000 (18:20 +0200)
qerror_report() is a transitional interface to help with converting
existing monitor commands to QMP.  It should not be used elsewhere.
Replace by error_report().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
tpm.c

diff --git a/tpm.c b/tpm.c
index 8dadc671aadccd993b57caec1eab630cc96cdea2..c8889fae79e4f7e1caf83ee811633c709a87c648 100644 (file)
--- a/tpm.c
+++ b/tpm.c
@@ -140,22 +140,21 @@ static int configure_tpm(QemuOpts *opts)
 
     id = qemu_opts_id(opts);
     if (id == NULL) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER, "id");
+        error_report(QERR_MISSING_PARAMETER, "id");
         return 1;
     }
 
     value = qemu_opt_get(opts, "type");
     if (!value) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER,
-                      "type");
+        error_report(QERR_MISSING_PARAMETER, "type");
         tpm_display_backend_drivers();
         return 1;
     }
 
     be = tpm_get_backend_driver(value);
     if (be == NULL) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_INVALID_PARAMETER_VALUE,
-                      "type", "a TPM backend type");
+        error_report(QERR_INVALID_PARAMETER_VALUE,
+                     "type", "a TPM backend type");
         tpm_display_backend_drivers();
         return 1;
     }