]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
ALSA: hda - Remove speaker clicks on CX20549
authorDavid Henningsson <david.henningsson@canonical.com>
Thu, 14 Feb 2013 10:36:39 +0000 (11:36 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 14 Feb 2013 10:54:43 +0000 (11:54 +0100)
This chip needs the speaker pin to go to D3 to avoid clicks,
so default_power_filter does not work here.

This was found on Thinkpad R61i/T61i but I guess it applies to
the entire chip. If not, quirks should be set for at least
PCI SSID 17aa:20ac.

Thanks to c4pp4 for testing.

BugLink: https://bugs.launchpad.net/bugs/886975
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_conexant.c

index 7d941ef54172b81058dd0d722f051459cab6e7d9..941bf6c766ecf5f6ff2aa35e28e33563066c58ef 100644 (file)
@@ -3350,6 +3350,7 @@ static int patch_conexant_auto(struct hda_codec *codec)
        switch (codec->vendor_id) {
        case 0x14f15045:
                codec->single_adc_amp = 1;
+               codec->power_filter = NULL; /* Needs speaker amp to D3 to avoid click */
                break;
        case 0x14f15047:
                codec->pin_amp_workaround = 1;