transports: ssh: report failure initializing libssh2

We unconditionally return success when initializing libssh2, regardless
of whether `libgssh2_init` signals success or an error. Fix this by
checking its return code.

diff --git a/src/transports/ssh.c b/src/transports/ssh.c
index 44d02e52298f506a97357e7d6ebee78ee7cd0276..d195d58ad0c914b78883168cc67fecd4d45a75ff 100644 (file)
--- a/src/transports/ssh.c
+++ b/src/transports/ssh.c
@@ -896,8 +896,11 @@ int git_transport_ssh_with_paths(git_transport **out, git_remote *owner, void *p
 int git_transport_ssh_global_init(void)
 {
 #ifdef GIT_SSH
+       if (libssh2_init(0) < 0) {
+               giterr_set(GITERR_SSH, "unable to initialize libssh2");
+               return -1;
+       }
 
-       libssh2_init(0);
        return 0;
 
 #else