]> git.proxmox.com Git - mirror_qemu.git/commitdiff
migration: don't use uninitialized variables
authorPawit Pornkitprasan <p.pawit@gmail.com>
Mon, 29 Jul 2013 23:39:52 +0000 (08:39 +0900)
committerLuiz Capitulino <lcapitulino@redhat.com>
Thu, 1 Aug 2013 13:40:46 +0000 (09:40 -0400)
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)

Signed-off-by: Pawit Pornkitprasan <p.pawit@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
migration.c

index 3f682cdc7fc4b44533444566ae58b27b9132bec7..1402fa7680faf788db47a1d0e60e00e2d348da55 100644 (file)
@@ -400,8 +400,8 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,
     MigrationParams params;
     const char *p;
 
-    params.blk = blk;
-    params.shared = inc;
+    params.blk = has_blk && blk;
+    params.shared = has_inc && inc;
 
     if (s->state == MIG_STATE_ACTIVE || s->state == MIG_STATE_SETUP) {
         error_set(errp, QERR_MIGRATION_ACTIVE);