]> git.proxmox.com Git - mirror_qemu.git/commitdiff
tests: tcg: do not use implicit rules
authorPaolo Bonzini <pbonzini@redhat.com>
Sat, 3 Oct 2020 07:00:46 +0000 (03:00 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Sun, 4 Oct 2020 16:36:23 +0000 (18:36 +0200)
Use pattern rules to clarify which targets are going to match the
rule and to provide clearer error messages.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tests/Makefile.include

index 40d909badcb81095d0e6731c9d969a0bc4610a51..5aca98e60c947bb9b59551806e71c672167d5871 100644 (file)
@@ -50,21 +50,21 @@ RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, $(TARGET_DIRS))
 $(foreach PROBE_TARGET,$(TARGET_DIRS),                                 \
        $(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs))
 
-build-tcg-tests-%: $(if $(CONFIG_PLUGIN),test-plugins)
+$(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if $(CONFIG_PLUGIN),test-plugins)
        $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
                -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
                SRC_PATH=$(SRC_PATH) \
                V="$(V)" TARGET="$*" guest-tests, \
                "BUILD", "TCG tests for $*")
 
-run-tcg-tests-%: build-tcg-tests-% all
+$(RUN_TCG_TARGET_RULES): run-tcg-tests-%: build-tcg-tests-% all
        $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
                -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
                SRC_PATH=$(SRC_PATH) SPEED="$(SPEED)" \
                V="$(V)" TARGET="$*" run-guest-tests, \
                "RUN", "TCG tests for $*")
 
-clean-tcg-tests-%:
+$(CLEAN_TCG_TARGET_RULES): clean-tcg-tests-%:
        $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
                -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
                SRC_PATH=$(SRC_PATH) TARGET="$*" clean-guest-tests, \