]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
[media] go7007: dubious one-bit signed bitfields
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Apr 2013 06:20:30 +0000 (03:20 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 22 Apr 2013 13:10:20 +0000 (10:10 -0300)
Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended.  It doesn't cause a bug, but it makes
Sparse complain:
drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/staging/media/go7007/go7007-priv.h

index 8bde187e4f900f48b75250d1a8a59f6b6282af5e..6e16af720504232e3ff3efbd9c64f29d31002772 100644 (file)
@@ -91,8 +91,8 @@ struct go7007_board_info {
        int num_i2c_devs;
        struct go_i2c {
                const char *type;
-               int is_video:1;
-               int is_audio:1;
+               unsigned int is_video:1;
+               unsigned int is_audio:1;
                int addr;
                u32 flags;
        } i2c_devs[5];