]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: dgap: Fix printk related errors as reported by checkpatch
authorMark Hounschell <markh@compro.net>
Mon, 3 Mar 2014 19:20:51 +0000 (14:20 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Mar 2014 20:05:20 +0000 (12:05 -0800)
This patch fixes some printk related errors report by checkpatch.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dgap/dgap.c

index cac2791b29fff87c68201bc6fae882c57ee001cd..29d38e7ac933dae01fa5545476d10fc9077283f0 100644 (file)
@@ -540,7 +540,7 @@ static int dgap_init_module(void)
                if (dgap_NumBoards)
                        pci_unregister_driver(&dgap_driver);
                else
-                       printk("WARNING: dgap driver load failed.  No DGAP boards found.\n");
+                       pr_err("dgap: driver load failed. No boards found.\n");
 
                dgap_cleanup_module();
        } else {
@@ -2948,7 +2948,6 @@ static int dgap_tty_write(struct tty_struct *tty, const unsigned char *buf, int
 
                if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *) buf, count)) {
                        up(&dgap_TmpWriteSem);
-                       printk("Write: Copy from user failed!\n");
                        return -EFAULT;
                }
 
@@ -6689,7 +6688,6 @@ static void dgap_create_tty_sysfs(struct un_t *un, struct device *c)
 
        ret = sysfs_create_group(&c->kobj, &dgap_tty_attribute_group);
        if (ret) {
-               printk(KERN_ERR "dgap: failed to create sysfs tty device attributes.\n");
                sysfs_remove_group(&c->kobj, &dgap_tty_attribute_group);
                return;
        }
@@ -7563,7 +7561,7 @@ static char *dgap_getword(char **in)
  */
 static void dgap_err(char *s)
 {
-       printk("DGAP: parse: %s\n", s);
+       pr_err("dgap: parse: %s\n", s);
 }
 
 /*